Check IS-11 control advertisement like other test suites do

[N-Nagorny]

Fixes the test that searches for IS-11 control advertisement in IS-04 APIs. For instance, this test fails with the following controls:

"controls": [
    {
        "href": "http://192.168.228.40:3215/x-nmos/connection/v1.0",
        "type": "urn:x-nmos:control:sr-ctrl/v1.0"
    },
    {
        "href": "http://192.168.100.40:3215/x-nmos/connection/v1.0",
        "type": "urn:x-nmos:control:sr-ctrl/v1.0"
    },
    {
        "href": "http://192.168.228.40:3215/x-nmos/connection/v1.1",
        "type": "urn:x-nmos:control:sr-ctrl/v1.1"
    },
    {
        "href": "http://192.168.100.40:3215/x-nmos/connection/v1.1",
        "type": "urn:x-nmos:control:sr-ctrl/v1.1"
    },
    {
        "href": "http://192.168.228.40:3216/x-nmos/events/v1.0",
        "type": "urn:x-nmos:control:events/v1.0"
    },
    {
        "href": "http://192.168.100.40:3216/x-nmos/events/v1.0",
        "type": "urn:x-nmos:control:events/v1.0"
    },
    {
        "href": "http://192.168.228.40:3215/x-nmos/channelmapping/v1.0",
        "type": "urn:x-nmos:control:cm-ctrl/v1.0"
    },
    {
        "href": "http://192.168.100.40:3215/x-nmos/channelmapping/v1.0",
        "type": "urn:x-nmos:control:cm-ctrl/v1.0"
    },
    {
        "href": "http://192.168.228.40:3218/x-nmos/streamcompatibility/v1.0",
        "type": "urn:x-nmos:control:stream-compat/v1.0"
    },
    {
        "href": "http://192.168.100.40:3218/x-nmos/streamcompatibility/v1.0",
        "type": "urn:x-nmos:control:stream-compat/v1.0"
    },
    {
        "href": "http://192.168.228.40:3212/x-manifest/",
        "type": "urn:x-nmos:control:manifest-base/v1.0"
    },
    {
        "href": "http://192.168.100.40:3212/x-manifest/",
        "type": "urn:x-nmos:control:manifest-base/v1.0"
    }

]

[garethsb]

LGTM

[alabou]

ISSUE: "[IS-11] Fix test 0.1 to look at all the devices exposing the IS-11 API #791" was supposed to fix that.

[garethsb]

@alabou that's the reported issue, this resolves the issue, and in the same way as IS-05 and IS-08 test suites. Is there a problem with that?

[alabou]

If there is only one good way of doing this check then the code should not be duplicated for each API but a common function should be used. The test plan has been updated last week to v0.9 and should be matching the IS-05, IS-08 code and Matrox IS-11 code. As discussed in the meeting Nikita will take care of using a common function in all the test suites without duplicating the code.

[garethsb]

I'd take correct code that fixes a demonstrated bug...