From b5c89095ffce009ae2e11f7c680572c599951876 Mon Sep 17 00:00:00 2001
From: Leon Vreling <l.m.vreling@student.tue.nl>
Date: Wed, 25 Sep 2024 20:34:52 +0200
Subject: [PATCH 1/2] fix(network): Change permission naming to allow saving of
 membership fee

---
 src/views/network/AntennaCriteriaModal.vue | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/views/network/AntennaCriteriaModal.vue b/src/views/network/AntennaCriteriaModal.vue
index d02279644..5f01f4e8c 100644
--- a/src/views/network/AntennaCriteriaModal.vue
+++ b/src/views/network/AntennaCriteriaModal.vue
@@ -13,7 +13,7 @@
             <option value="null">Not set</option>
             <option value="true">Yes</option>
             <option value="false">No</option>
-            <option v-if="can.giveExceptionCommunication" value="exception">Exception</option>
+            <option v-if="can.setCommunicationException" value="exception">Exception</option>
           </b-select>
 
           <b-input v-model="comments.communication" placeholder="Comment" expanded />
@@ -58,7 +58,7 @@
         </b-field>
       </template>
 
-      <template v-if="can.setMembershipFeePayement">
+      <template v-if="can.setMembershipFee">
         <b-field label="Membership fee (F)" />
         <b-field grouped>
           <b-select v-model="antennaCriteria.membershipFee">
@@ -170,10 +170,10 @@ export default {
       permissions: [],
       can: {
         setCommunication: false,
-        giveExceptionCommunication: false,
+        setCommunicationException: false,
         setBoardElection: false,
         setMembersList: false,
-        setMembershipFeePayement: false,
+        setMembershipFee: false,
         setEvents: false,
         setAgoraAttendance: false,
         setDevelopmentPlan: false,
@@ -228,10 +228,10 @@ export default {
     this.axios.get(this.services['core'] + '/my_permissions').then((permissionResponse) => {
       this.permissions = permissionResponse.data.data
       this.can.setCommunication = this.permissions.some(permission => permission.combined.endsWith('manage_network:communication'))
-      this.can.giveExceptionCommunication = this.permissions.some(permission => permission.combined.endsWith('manage_network:communication_exception'))
+      this.can.setCommunicationException = this.permissions.some(permission => permission.combined.endsWith('manage_network:communication_exception'))
       this.can.setBoardElection = this.permissions.some(permission => permission.combined.endsWith('manage_network:board_election'))
       this.can.setMembersList = this.permissions.some(permission => permission.combined.endsWith('manage_network:members_list'))
-      this.can.setMembershipFeePayement = this.permissions.some(permission => permission.combined.endsWith('manage_network:membership_fee'))
+      this.can.setMembershipFee = this.permissions.some(permission => permission.combined.endsWith('manage_network:membership_fee'))
       this.can.setEvents = this.permissions.some(permission => permission.combined.endsWith('manage_network:events'))
       this.can.setAgoraAttendance = this.permissions.some(permission => permission.combined.endsWith('manage_network:agora_attendance'))
       this.can.setDevelopmentPlan = this.permissions.some(permission => permission.combined.endsWith('manage_network:development_plan'))

From ea2d0f06ba3e1f0ea5c06830ed59bd7f83603760 Mon Sep 17 00:00:00 2001
From: Leon Vreling <l.m.vreling@student.tue.nl>
Date: Wed, 25 Sep 2024 20:38:17 +0200
Subject: [PATCH 2/2] fix(network): Remove the automatic checking of SU

Request from the ND such that instead of checking all events manually, most of them are checked correctly on production
---
 src/views/network/AntennaCriteriaCheck.vue | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/views/network/AntennaCriteriaCheck.vue b/src/views/network/AntennaCriteriaCheck.vue
index 4aff606cf..91553ae29 100644
--- a/src/views/network/AntennaCriteriaCheck.vue
+++ b/src/views/network/AntennaCriteriaCheck.vue
@@ -4,6 +4,10 @@
       <article class="tile is-child">
         <h4 class="title">Antenna Criteria Check</h4>
 
+        <div class="notification is-warning">
+          The computation of the fulfilment of 'Events' is currently not working correctly. It does <strong>not</strong> yet take into account the Summer Universities organised. Please check these manually!
+        </div>
+
         <div class="field">
           <label class="label">Selected Agora</label>
           <div class="select">
@@ -308,7 +312,7 @@ export default {
       const promises = []
       promises.push(this.fetchEvents())
       promises.push(this.fetchStatutoryEvents())
-      promises.push(this.fetchSummerUniversities())
+      // promises.push(this.fetchSummerUniversities())
 
       await Promise.all(promises)
 
@@ -325,12 +329,12 @@ export default {
         body.latest_event = !body.latest_event || moment(event.latest_event).isAfter(moment(body.latest_event)) ? event.latest_event : body.latest_event
       }
 
-      for (const event of this.summerUniversities) {
-        for (const organizer of event.organizing_bodies) {
-          const body = this.bodies.find(x => x.id === organizer.body_id)
-          body.latest_event = !body.latest_event || moment(event.latest_event).isAfter(moment(body.latest_event)) ? event.latest_event : body.latest_event
-        }
-      }
+      // for (const event of this.summerUniversities) {
+      //   for (const organizer of event.organizing_bodies) {
+      //     const body = this.bodies.find(x => x.id === organizer.body_id)
+      //     body.latest_event = !body.latest_event || moment(event.latest_event).isAfter(moment(body.latest_event)) ? event.latest_event : body.latest_event
+      //   }
+      // }
       // ... until here
 
       for (const body in this.bodies) {